Built by Maven

PMD Results

The following document contains the results of PMD 6.55.0.

Violations By Priority

Priority 1

jp/sourceforge/jindolf/corelib/PreDefAvatar.java

Rule Violation Line
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 50

Priority 3

jp/sourceforge/jindolf/corelib/DateUtils.java

Rule Violation Line
UnusedAssignment The updated value of variable 'gid' is never used 89
LiteralsFirstInComparisons Position literals first in String comparisons 99

jp/sourceforge/jindolf/corelib/DomUtils.java

Rule Violation Line
UseTryWithResources Consider using a try-with-resources statement instead of explicitly closing the resource 76–80

jp/sourceforge/jindolf/corelib/GameRole.java

Rule Violation Line
LongVariable Avoid excessively long variable names like BALANCE_COMPARATOR 37
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 38
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 180

jp/sourceforge/jindolf/corelib/LandDef.java

Rule Violation Line
GodClass Possible God Class (WMC=75, ATFD=32, TCC=0.568%) 31–599
TooManyMethods This class has too many methods, consider refactoring it. 31–599
TooManyFields Too many fields 31–599
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 216
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 595

jp/sourceforge/jindolf/corelib/PreDefAvatar.java

Rule Violation Line
DataClass The class 'PreDefAvatar' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=5, WMC=20) 22–167
CyclomaticComplexity The constructor 'PreDefAvatar(String, String, String, String, int)' has a cyclomatic complexity of 10. 39–66
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 103
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 108

jp/sourceforge/jindolf/corelib/VillageTag.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 106

jp/sourceforge/jindolf/corelib/XmlResource.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 122

jp/sourceforge/jindolf/corelib/package-info.java

Rule Violation Line
CommentSize Comment is too large: Too many lines 13–66

Files

jp/sourceforge/jindolf/corelib/DateUtils.java

Rule Violation Priority Line
UnusedAssignment The updated value of variable 'gid' is never used 3 89
LiteralsFirstInComparisons Position literals first in String comparisons 3 99

jp/sourceforge/jindolf/corelib/DomUtils.java

Rule Violation Priority Line
UseTryWithResources Consider using a try-with-resources statement instead of explicitly closing the resource 3 76–80

jp/sourceforge/jindolf/corelib/GameRole.java

Rule Violation Priority Line
LongVariable Avoid excessively long variable names like BALANCE_COMPARATOR 3 37
AccessorClassGeneration Avoid instantiation through private constructors from outside of the constructors class. 3 38
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 3 180

jp/sourceforge/jindolf/corelib/LandDef.java

Rule Violation Priority Line
GodClass Possible God Class (WMC=75, ATFD=32, TCC=0.568%) 3 31–599
TooManyMethods This class has too many methods, consider refactoring it. 3 31–599
TooManyFields Too many fields 3 31–599
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 216
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 595

jp/sourceforge/jindolf/corelib/PreDefAvatar.java

Rule Violation Priority Line
DataClass The class 'PreDefAvatar' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=5, WMC=20) 3 22–167
CyclomaticComplexity The constructor 'PreDefAvatar(String, String, String, String, int)' has a cyclomatic complexity of 10. 3 39–66
AvoidThrowingNullPointerException Avoid throwing null pointer exceptions. 1 50
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 103
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 108

jp/sourceforge/jindolf/corelib/VillageTag.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 106

jp/sourceforge/jindolf/corelib/XmlResource.java

Rule Violation Priority Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 122

jp/sourceforge/jindolf/corelib/package-info.java

Rule Violation Priority Line
CommentSize Comment is too large: Too many lines 3 13–66